Skip to content

feat(UI): move sponsor progress to Configuration tab#2153

Merged
AprilSylph merged 1 commit intomasterfrom
aprilsylph/sticky-sponsor-progress
Mar 18, 2026
Merged

feat(UI): move sponsor progress to Configuration tab#2153
AprilSylph merged 1 commit intomasterfrom
aprilsylph/sticky-sponsor-progress

Conversation

@AprilSylph
Copy link
Owner

Description

Moves the sponsor progress element from the Links tab to the Configuration tab, and makes it stick to the bottom of the viewport.

This was a lot less complicated than I thought it would be! This is the first time that position: sticky; bottom: 0; has done what I want it to do.

Before Before After After
Screen Shot 2026-03-17 at 10 56 36 Screen Shot 2026-03-17 at 10 56 48 Screen Shot 2026-03-17 at 10 57 07 Screen Shot 2026-03-17 at 10 57 13

Testing steps

  1. Load the modified addon
  2. Open the XKit control panel
    • Expected result: The sponsor progress element is immediately visible, and loads my sponsor goal progress
  3. Scroll the Configuration tabpanel
    • Expected result: The sponsor progress element keeps its position
    • Expected result: The sponsor progress element's presence does not prevent you from seeing the last feature in the list

The other half of validating this PR is your opinion on whether or not this is okay to add, or if you believe my own goal is unreasonable in the face of your (so far, unpaid) contributions. I will not make this change without your consent.

Copy link
Collaborator

@marcustyphoon marcustyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this on the other pane too, but it doesn't look the way you would want if your browser window is taller than the scrollable list :D Fortunately, the configuration pane is very tall, so this should not be a problem.

  • firefox, dropdown
  • firefox, extension preferences
  • chrome, dropdown
  • chrome, extension preferences
  • safari, dropdown
  • safari ios iphone simulator (edges cut off unless you scroll down to the bottom, but this qualifies as functional and we don't support this platform anyway; this is just for completeness/to avoid technical debt accumulating in case we ever do)
  • safari ios ipad simulator
  • firefox android

@marcustyphoon
Copy link
Collaborator

(Oh yeah. And if I thought that you were a) going to become independently wealthy off donations for a tool for a site the userbase won't fund, and that b) if that scenario occurred we wouldn't revisit this, then sure, maybe I'd have some reservations. But, you know, then you wouldn't be asking :D)

@AprilSylph
Copy link
Owner Author

A tiny bit janky on Android because the features list actually takes a noticeable amount of time to load. Not bad enough to block this, but bad enough to be worth a followup PR.

@AprilSylph AprilSylph merged commit 09ba0d3 into master Mar 18, 2026
5 checks passed
@AprilSylph AprilSylph deleted the aprilsylph/sticky-sponsor-progress branch March 18, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants